Use markdown parsing for fenced code blocks#9
Use markdown parsing for fenced code blocks#9czipperz wants to merge 1 commit intopolymode:masterfrom
Conversation
czipperz
force-pushed
the
markdown-parsing-fenced-code-blocks
branch
2 times, most recently
from
a8e8984 to
d6efcb2
Compare
poly-markdown.el
Outdated
| :allow-nested nil) | ||
|
|
||
| (defun poly-markdown-fenced-code-begin-accessor (val) | ||
| (cons (point) |
There was a problem hiding this comment.
Why not just (cons (car val) (cadr val))? Those are the locations of the property.
There was a problem hiding this comment.
In fact I would prefer to match without relying on the accessor because those properties could be potentially moved and not immediately updated.
This increment at the end of the property is a common requirement. YAML should also do that. So I have implemented a simple :inc-end accessor for pm-make-text-property-matcher.
vspinu
force-pushed
the
markdown-parsing-fenced-code-blocks
branch
from
bb9f79b to
5832c42
Compare
|
I have force-pushed to your branch the new way of doing that increment. One deletion test is failing though. |
|
I cannot reproduce the issue when replicating the steps interactively but I do see other issues when deleting fences. So I am afraid this part is challenging and doesn't quite work. We will have to pause on it for a while. |
|
It's in this code chunk. I think it needs to somehow refresh the markdown faces since we now rely on them. If we delete these four lines, the tests pass: https://github.com/czipperz/poly-markdown/blob/markdown-parsing-fenced-code-blocks/tests/poly-markdown-tests.el#L124-L127 |
2 participants
No description provided.